Skip to content

[browser][CoreCLR] fix pinvoke #123423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pavelsavara merged 5 commits into from
Jan 21, 2026
Merged

[browser][CoreCLR] fix pinvoke #123423

pavelsavara merged 5 commits into from
Jan 21, 2026

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 21, 2026

Fixes #123421

@pavelsavara pavelsavara added this to the 11.0.0 milestone Jan 21, 2026
@pavelsavara pavelsavara self-assigned this Jan 21, 2026
Copilot AI review requested due to automatic review settings January 21, 2026 09:20
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Interop-coreclr os-browser Browser variant of arch-wasm labels Jan 21, 2026
radekdoulik
radekdoulik approved these changes Jan 21, 2026
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jan 21, 2026

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a PInvoke issue in browser/CoreCLR builds by adding two missing browser-specific native modules to the WasmAppBuilder's list of PInvoke modules.

Changes:

  • Added libSystem.Native.Browser and libSystem.Runtime.InteropServices.JavaScript.Native to the WasmPInvokeModule list in the RunGenerator target

pavelsavara added a commit to pavelsavara/runtime that referenced this pull request Jan 21, 2026
@pavelsavara
with dotnet#123423
91c8c9c
@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 21, 2026

Looks good now

System.Runtime.InteropServices.JavaScript.Tests

System.Runtime.Tests

@pavelsavara pavelsavara enabled auto-merge (squash) January 21, 2026 12:02
@pavelsavara pavelsavara merged commit 92d46b9 into dotnet:main Jan 21, 2026
118 checks passed
@pavelsavara pavelsavara deleted the browser_fix_pinvoke branch January 21, 2026 13:08
This was referenced Jan 21, 2026
Closed
Merged
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara mentioned this pull request Jan 21, 2026
Merged
@dotnet-maestro dotnet-maestro bot mentioned this pull request Jan 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@radekdoulik radekdoulik radekdoulik approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-Interop-coreclr os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

11.0.0

Development

Successfully merging this pull request may close these issues.

[browser][coreCLR] Unable to load shared library libSystem.Runtime.InteropServices.JavaScript.Native

2 participants

@pavelsavara @radekdoulik